Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct privateNetworks range typo #5915

Merged
merged 1 commit into from Jan 28, 2022
Merged

Correct privateNetworks range typo #5915

merged 1 commit into from Jan 28, 2022

Conversation

jprenken
Copy link
Contributor

Fixes #5914

@jprenken jprenken requested a review from a team as a code owner January 28, 2022 07:34
@beautifulentropy
Copy link
Member

Let me know if it's okay to merge this.

@pgporada
Copy link
Member

Fwiw zlint has a check for this https://github.com/zmap/zlint/blob/master/v3/util/ip.go#L93

@aarongable aarongable merged commit 13214b8 into letsencrypt:main Jan 28, 2022
aarongable pushed a commit that referenced this pull request Jan 28, 2022
@jprenken @aarongable
Correct privateNetworks range typo (#5915)
09db455 
Fixes #5914

(cherry picked from commit 13214b8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongable aarongable aarongable approved these changes

@beautifulentropy beautifulentropy beautifulentropy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect privateNetworks range in bdns/dns.go
4 participants
@jprenken @beautifulentropy @pgporada @aarongable